use nanoid for workflow ids (temporalio#131)

Fix temporalio#110
field-energy · Apr 12, 2022 · d72ab5b · d72ab5b
1 parent b601ce6
commit d72ab5b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/grpc-calls/package.json b/grpc-calls/package.json
@@ -20,6 +20,7 @@
     ]
   },
   "dependencies": {
+    "nanoid": "3.x",
     "temporalio": "0.20.x"
   },
   "devDependencies": {

diff --git a/grpc-calls/src/client.ts b/grpc-calls/src/client.ts
@@ -1,9 +1,10 @@
 import { Connection } from '@temporalio/client';
 import { defaultPayloadConverter, toPayloads } from '@temporalio/common';
+import { nanoid } from 'nanoid';
 
 async function run() {
-  const workflowId = 'wf-id-' + Math.floor(Math.random() * 1000);
-  const requestId = 'request-id-' + Math.floor(Math.random() * 1000);
+  const workflowId = 'workflow-' + nanoid();
+  const requestId = 'request-' + nanoid();
   // @@@SNIPSTART typescript-grpc-call-basic
   const connection = new Connection();
 

diff --git a/hello-world/package.json b/hello-world/package.json
@@ -20,6 +20,7 @@
     ]
   },
   "dependencies": {
+    "nanoid": "3.x",
     "temporalio": "0.20.x"
   },
   "devDependencies": {

diff --git a/hello-world/src/client.ts b/hello-world/src/client.ts
@@ -1,6 +1,7 @@
 // @@@SNIPSTART typescript-hello-client
 import { Connection, WorkflowClient } from '@temporalio/client';
 import { example } from './workflows';
+import { nanoid } from 'nanoid';
 
 async function run() {
   const connection = new Connection({
@@ -18,7 +19,7 @@ async function run() {
     args: ['Temporal'], // type inference works! args: [name: string]
     taskQueue: 'hello-world',
     // in practice, use a meaningful business id, eg customerId or transactionId
-    workflowId: 'wf-id-' + Math.floor(Math.random() * 1000),
+    workflowId: 'workflow-' + nanoid(),
   });
   console.log(`Started workflow ${handle.workflowId}`);