merge

.gitpod.yml

@@ -10,19 +10,19 @@ tasks:
       npm install
     command: |
       gp open .gitpod.readme.md
-      gp sync-await server-up
       cd hello-world
+      sleep 30
       npm run start.watch
   - name: Run Hello World Workflow
     init: |
       alias tctl="docker exec temporal-admin-tools tctl"
       echo "tctl configured! try typing tctl -v" # can't run tctl directly from gitpod.yml
     command: |
       cd hello-world
-      until npm run workflow; do sleep 5; done; # "sleep until temporal is actually up"
-      gp sync-done server-up
-      gp preview http://localhost:8088 # open up Temporal Web to show new workflow
+      sleep 30
       npm run workflow # run workflow again for user's easy access
+      sleep 5
+      gp preview http://localhost:8088 # open up Temporal Web to show new workflow
     openMode: split-right
   - name: Temporal Server
     init: docker-compose pull

.shared/.eslintrc.js

@@ -19,8 +19,8 @@ module.exports = {
 
     // code style preference
     'object-shorthand': ['error', 'always'],
-    
-     // relaxed rules, for convenience
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {

activities-cancellation-heartbeating/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

activities-dependency-injection/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

activities-examples/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

activities-sticky-queues/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

child-workflows/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

continue-as-new/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

cron-workflows/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

dsl-interpreter/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

dsl-interpreter/src/workflows.ts

@@ -29,10 +29,7 @@ export async function DSLInterpreter(dsl: DSL): Promise<unknown> {
   return await execute(dsl.root, bindings);
 }
 
-async function execute(
-  statement: Statement,
-  bindings: Record<string, string | undefined>
-): Promise<void> {
+async function execute(statement: Statement, bindings: Record<string, string | undefined>): Promise<void> {
   // note that this function returns void
   // we don't assign the results here - all results must be declared+bound in the activity DSL
   if ('parallel' in statement) {

expense/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

hello-world-mtls/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

hello-world/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

hello-world/README.md

@@ -9,10 +9,12 @@ The [Hello World Tutorial](https://docs.temporal.io/docs/typescript/hello-world/
 1. Make sure Temporal Server is running locally (see the [quick install guide](https://docs.temporal.io/docs/server/quick-install/)).
 1. `npm install` to install dependencies.
 1. `npm run start.watch` to start the Worker.
-1. In another shell, `npm run workflow` to run the Workflow.
+1. In another shell, `npm run workflow` to run the Workflow Client.
 
-The Workflow should return:
+The client should log the Workflow ID that is started, and you should see it reflected in Temporal Web UI.
 
-```
+Optionally, you can also uncomment the `await handle.result()`, rerun, and see the client script return:
+
+```bash
 Hello, Temporal!
 ```

hello-world/src/client.ts

@@ -12,12 +12,14 @@ async function run() {
   });
 
   // Invoke the `example` Workflow, only resolved when the workflow completes
-  const result = await client.execute(example, {
+  const handle = await client.start(example, {
     args: ['Temporal'], // type inference works! args: [name: string]
     taskQueue: 'tutorial',
     workflowId: 'my-business-id',
   });
-  console.log(result); // Hello, Temporal!
+  console.log(`Started workflow ${handle.workflowId}`);
+  // optional: wait for client result
+  // console.log(await handle.result()); // Hello, Temporal!
 }
 
 run().catch((err) => {

instrumentation/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };

interceptors-opentelemetry/.eslintrc.js

@@ -13,6 +13,14 @@ module.exports = {
     'prettier',
   ],
   rules: {
+    // recommended for safety
+    '@typescript-eslint/no-floating-promises': 'error', // forgetting to await Activities and Workflow APIs is bad
+    'deprecation/deprecation': 'warn',
+
+    // code style preference
+    'object-shorthand': ['error', 'always'],
+
+    // relaxed rules, for convenience
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
@@ -21,8 +29,5 @@ module.exports = {
       },
     ],
     '@typescript-eslint/no-explicit-any': 'off',
-    '@typescript-eslint/no-floating-promises': 'error',
-    'object-shorthand': ['error', 'always'],
-    'deprecation/deprecation': 'warn',
   },
 };