-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic support for Biome #316
Conversation
🦋 Changeset detectedLatest commit: a06f0df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@fi3ework any concerns about this? |
This is all that's holding us back from adopting Biome ATM. When will you merge this? |
@fi3ework , any chance to merge this, maybe with an experimental |
As this is not getting merged, I am going to create a temporary fork and merge this there. I want to get out of ESlint ecosystem soon and this is blocking me. Edit: My fork is ready and can be installed as |
@KurtGokhan the failed tests, was it just a faulty run or is it broken in those scenarios? asking mostly because of node-20 ubuntu |
@kamikazePT Tests are faulty for quite some time - see #264. Seems like they are getting fixed in PR #327. |
Thanks @KurtGokhan for your contributing, and sorry for the long time to respond. I tweaked the code and it almost done. While there's something wrong when updating file diagnostic on Windows (I guess that's caused by the mix use of |
@fi3ework Thanks a lot for the updates. It looks much more polished now. I noticed the issue now. Will try to fix it. |
The issue should be fixed now. Although now I think, it would be easier to just re-run Biome on all files on every file change, and it wouldn't even be noticeable because Biome is so fast. Maybe can add it as an option later. |
If we could make it incremental and scalable now, we'd keep in this way. Full re-scan will take up all CPU resources (I guess, Biome will try to use the utmost resource it could), and that could cause a lag in user's device. |
Thank you very much @KurtGokhan. |
Fixes #279
Mostly based on the ESLint checker.
I can add examples later.
I tried to create an example in StackBlitz but Biome doesn't work in StackBlitz for now.
CodeSandbox example