-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.7 #258
Conversation
|
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0dbe77d
to
5fe5300
Compare
"vscode-languageclient": "^7.0.0", | ||
"vscode-languageserver": "^7.0.0", | ||
"vscode-languageserver-textdocument": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those dependencies should be moved to vls package, as thats the only one that requires it
import fs from 'fs' | ||
import { createRequire } from 'module' | ||
import os from 'os' | ||
import os from 'node:os' | ||
import strip from 'strip-ansi' | ||
import * as _vscodeUri from 'vscode-uri' | ||
|
||
// hack to compatible with Jiti | ||
// see details: https://github.com/fi3ework/vite-plugin-checker/issues/197 | ||
// @ts-expect-error | ||
const URI = _vscodeUri?.default?.URI ?? _vscodeUri.URI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this "hack" should be moved to places where we import vscode-uri
, as its no longer used in here we should remove it from this file
we should move it to vls package with its depencency
let level = DiagnosticLevel.Error | ||
switch (d.severity) { | ||
case 0: // off, ignore this | ||
level = DiagnosticLevel.Error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this assign is unnecessary
v0.7 is set to release with an important fix of compatibility with vue-tsc@2. A lot of changes has made since then. It might be possible to release a v0.8 to compatible with ESLint 9. Then will start a 0.10.0 with separate checkers into different packages. I'll start to do this over again. |
v0.7
Breaking changes:
💥 Split check abilities into separate packages
After v0.7, the usage will be like:
package.json
vite config
Why?
💥 Remove default export support
After v0.7, no default export will be provided from vite-plugin-checker to reduce ESM and CJS potential issues. The named export
checker
will be the only one to use. Also, new added checker packages will not provide default export but also a named exportchecker
.