Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Fede,
As discussed I gave it a shot to integrate the Blinkmoji web app with your repo.
Summary of changes
script.js
to extract common functionality for just controlling the blinkenlights to a separate script calledblinken.js
Requirements on the server side
As specified on my original repo page (https://github.com/mbalasz/blinkmoji#requirements) the server hosting the web app needs to have ImageMagick installed. It also needs the
Noto Color Emoji
font.Local testing
npm install
to download some extra node modulespackage.json
of the module that provides emoji icons. So locally I recommend you add those linesnode server.js
localhost:3000/blinkmoji
New Branch?
I'd be happy to merge this into a separate branch as opposed to
main
to start with. However, I think you'd need to first create such branch.I'm happy to chat more about this PR before moving forward. Just wanted to have some draft ready.