Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Superscripts #10

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add Superscripts #10

merged 1 commit into from
Jan 31, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Jan 31, 2024

Purpose/implementation Section

What changes are being implemented in this Pull Request?

For issue #8, correcting the citations to be rendered superscripts.

What was your approach?

Switched from ^# to <sup>#</sup>

What GitHub issue does your pull request address?

Addresses issue #8

Copy link
Contributor

github-actions bot commented Jan 31, 2024

No broken urls! 🎉
Comment updated at 2024-01-31 with changes from 2d0b1ca

Copy link
Contributor

Re-rendered previews from the latest commit:

Updated at 2024-01-31 with changes from 2d0b1ca

@kweav kweav requested a review from ehumph January 31, 2024 21:37
Copy link
Contributor

@ehumph ehumph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Ava mentioned there is an OTTR-specific way to include hyperlinks, but I think this looks great for now

@kweav
Copy link
Contributor Author

kweav commented Jan 31, 2024

I can work on the OTTR hyperlinks. Are you thinking you'd want the superscripts to be hyperlinked? Do you still want the References section?

@kweav kweav merged commit c7742d3 into main Jan 31, 2024
6 checks passed
@kweav
Copy link
Contributor Author

kweav commented Jan 31, 2024

OTTR hyperlinks using the author contribution table method or the citing sources method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants