Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): Use serializer for multipart form data when noSerde: false #5598

Merged
merged 16 commits into from
Jan 14, 2025

Conversation

Swimburger
Copy link
Member

@Swimburger Swimburger commented Jan 13, 2025

Description

  • Use Serde to convert types to mapped value, and JSON stringify if not already a string.
  • Use Serde for named types and array/set of named types in query strings, except for aliases
    to primitive types.
    If the named type is an alias of the primitive type, use the primitive type's stringify.

This fixes multipart file uploads with JSON parts when serde is enabled.

Testing

  • Seed

@Swimburger Swimburger marked this pull request as ready for review January 14, 2025 18:41
@Swimburger Swimburger requested a review from dsinghvi as a code owner January 14, 2025 18:41
Copy link
Member

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Swimburger Swimburger merged commit 9cdb96c into main Jan 14, 2025
49 of 50 checks passed
@Swimburger Swimburger deleted the niels/typescript/fix-multipart-form-json-casing branch January 14, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants