-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Add support for in-lined path parameters #5231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amckinney
changed the title
feat(cli): [WIP] Add support for in-lined path parameters
feat(cli): Add support for in-lined path parameters
Nov 20, 2024
dsinghvi
reviewed
Nov 21, 2024
packages/cli/api-importers/openapi/openapi-ir-to-fern/src/buildEndpoint.ts
Outdated
Show resolved
Hide resolved
dsinghvi
reviewed
Nov 21, 2024
...lidator/src/rules/valid-path-parameters-configuration/valid-path-parameters-configuration.ts
Outdated
Show resolved
Hide resolved
dsinghvi
reviewed
Nov 21, 2024
dsinghvi
approved these changes
Nov 21, 2024
…fern into amckinney/fern/path-parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for including
path-parameters
in therequest
section of the endpoint definition. This includes:fern check
rule which ensures that only onepath-parameters
block is present for any endpoint.inline-path-parameters
OpenAPI importer setting.With this, both
path-parameters
formats are supported so that users can configure an endpoint like so:Note that a new
path-parameters
test definition was added, and some generators might produce an in-lined request type alongside positional path parameters. This case should be handled within each generator with a generator-specificinlinePathParameters
configuration option.