Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(seed): seed run command matches with docker config #4605

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Sep 10, 2024

Previously when you would run pnpm seed:local run it would override the generators yaml configuration that you would point to. Now it doesn't.

AI Description

This PR introduces a new image field to the SeedWorkspaceConfiguration type in the config.yml file. The image field is also added to the SeedWorkspaceConfigurationinterface in theSeedWorkspaceConfiguration.ts` file.

The `image field is then populated with a string value in the following files:

  • seed/csharp-model/seed.yml
  • seed/csharp-sdk/seed.yml
  • seed/fastapi/seed.yml
  • seed/go-fiber/seed.yml
  • seed/go-model/seed.yml
  • seed/go-sdk/seed.yml
  • seed/java-model/seed.yml
  • seed/java-sdk/seed.yml
  • seed/java-spring/seed.yml
  • seed/openapi/seed.yml
  • seed/php-model/seed.yml
  • seed/php-sdk/seed.yml
  • seed/postman/seed.yml
  • seed/pydantic/seed.yml
  • seed/python-sdk/seed.yml
  • seed/ruby-model/seed.yml
  • seed/ruby-sdk/seed.yml
  • seed/ts-express/seed.yml
  • seed/ts-sdk/seed.yml

Additionally, the Language type in the Language.tsfile is updated to include thephp` language.

The runWithCustomFixture.ts and DockerTestRunner.ts files are also modified to include new functions and imports related to the `image field.

@dsinghvi dsinghvi force-pushed the dsinghvi/docker-run-picks-up-config branch from 2dcf963 to 5a00fd7 Compare September 10, 2024 20:45
@dsinghvi dsinghvi merged commit 44e0365 into main Sep 10, 2024
41 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/docker-run-picks-up-config branch September 10, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant