fix(python): handle non union self referencing schemas #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armandobelardo
approved these changes
Sep 10, 2024
dsinghvi
force-pushed
the
dsinghvi/handle-non-union-references-from-pydantic-models
branch
from
ffbf284 to
b31473e
Compare
dsinghvi
deleted the
dsinghvi/handle-non-union-references-from-pydantic-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates forward refs for non union self referencing schemas so that the Python SDK can appropriately build.
AI generated Summary
This pull request introduces a new method,
get_non_union_circular_references, to thePydanticGeneratorContextandFernAwarePydanticModelclasses. This method is used to identify non-union circular references within the context of type generation.Changes
get_non_union_circular_referencesmethod is added to thePydanticGeneratorContextclass, which returns a set of type IDs that are non-union circular references.get_non_union_circular_referencesmethod is also added to theFernAwarePydanticModelclass, which returns a set of type IDs that are non-union circular references._must_import_after_current_declarationmethod in theFernAwarePydanticModelclass is updated to check for non-union circular references using the newget_non_union_circular_referencesmethod.