[DNM, Dupe] fix(cli): namespacing no longer breaks when objects conflict across namespaces #4596
Conversation
| const declarationFile = getDeclarationFileForSchema(schema); | ||
| const typeDeclaration = buildTypeDeclaration({ schema, context, declarationFile }); | ||
| const declarationFile = getDeclarationFileForSchema(schema); | ||
| const typeDeclaration = buildTypeDeclaration({ schema, context, declarationFile, namespace }); |
There was a problem hiding this comment.
This is really only nesting the for loop into another for loop, the only actual change is passing in namespace here
| x-fern-type-name: Pets | ||
| Error: | ||
| x-fern-type-name: Error | ||
| __no_namespace__: |
There was a problem hiding this comment.
I'm not positive what would cause this
armandobelardo
changed the title
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
| import { Namespace, SdkGroupName, EndpointSdkName } from "@fern-api/openapi-ir-sdk"; | ||
|
|
||
| export function getNamespaceFromGroup(groupName: SdkGroupName): string | undefined { | ||
| return groupName.find((group): group is Namespace => typeof group !== "string" && group.type === "namespace")?.name; |
There was a problem hiding this comment.
nit: this would be easier to read if we refactored the type guard outside of the lambda
| The schemas are organized by namespace and schema name. | ||
| The schema name is the key in the inner map. | ||
| Note that this also includes un-namespaced schemas with a static sentinel key of `__no_namespace__`, | ||
| as even when namespacing we allow for root, unnamespaced APIs, and this allows for the most flexibility. |
dsinghvi
force-pushed
the
ab/fix-namespacing
branch
from
c4fde91 to
7b4ae37
Compare
armandobelardo
changed the title
For now, this just adds a repro of the namespace break, you can see in the ETE test,
trainsimports fromneopets(a different namespace) when the objects share the same name