chore(csharp): refactor writer, ast node, and code block into commons #4578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amckinney
reviewed
Sep 9, 2024
| */ | ||
| public writeNodeStatement(node: AbstractAstNode): void { | ||
| node.write(this); | ||
| this.write(";"); |
There was a problem hiding this comment.
Details like this might need to be left out of the abstract classes - not every language ends statements with a ;. I know most languages do use this syntax though, so we have a couple options:
- Leave this as-is and rely on method overrides in language-specific writers.
- Refactor the
AbstractWriterto be fairly similar to the originalgenerators/commons.Writer.
You might have already had (1) as the desired solution, but figured it was worth calling out.
| * Writes text but then suffixes with a `;` | ||
| * @param node | ||
| */ | ||
| public controlFlow(prefix: string, statement: AbstractAstNode): void { |
There was a problem hiding this comment.
Similar to above - control flow and blocks will differ based on the language, so the decision applies here too.
| @@ -5,7 +5,7 @@ import { FernGeneratorCli } from "@fern-fern/generator-cli-sdk"; | |||
| import { readFile } from "fs/promises"; | |||
| import yaml from "js-yaml"; | |||
| import path from "path"; | |||
| import { ReferenceConfigBuilder } from "./ReferenceConfigBuilder"; | |||
| import { ReferenceConfigBuilder } from "./reference"; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we update the generator commons package to export an
AbstractWriter,AbstractAstNodeandCodeBlock. These core building blocks will help hit the ground running as new generators are added.