(feature): Add support for .proto inputs
#4223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
Aug 7, 2024
packages/cli/workspace-loader/src/protobuf/ProtobufOpenAPIGenerator.ts
Outdated
Show resolved
Hide resolved
dsinghvi
approved these changes
Aug 8, 2024
dsinghvi
pushed a commit
that referenced
this pull request
Aug 9, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
.protofiles as input. This is handled via a newAPIDefinitionSchematype which can be any of the following:For now, we compile the Protobuf files locally, but we eventually plan to handle this an endpoint call, so we include a
local-generationflag to switch on so we reserve the default behavior for remote generation (supported in a later change).Note that this also updates all of the
seedworkflows by splitting out the setup stage into a callablesetup-seed.ymlworkflow. This file is unused for now since it needs to be available onmain, but its setup for a simple refactor later on.