(fix, go): Don't send 'null' for nil request body #3987
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Go's
core.Caller
abstraction so that we don't send an explicitnull
whenever the user sets anil
request type (i.e. for POST requests). Instead, no request body is sent. An additional unit test is included in the generatedcore_test.go
file, too.Given that we already use the
reflect
package for query parameter serialization, this opts to use the simplerreflect
solution to determine whether or not aninterface
value type is set tonil
(i.e. via the newisNil
helper function).RequestIsNil
sentinel value (because the generated client code can distinguish whether or not the struct type isnil
at thecore.Caller
call-site).