Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(internal, seed): heavy rewrite of seed #3297

Merged
merged 12 commits into from
Apr 21, 2024
Merged

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Mar 31, 2024

This PR pushes a large refactor to seed. In particular, the following things have changed:

  • Instead of --workspace we now specify --generator <generator>. So to run tests on the python-sdk you can do yarn seed test --generator python-sdk.
  • Instead of a gigantic file with one function, we know have a TestRunner and ScriptRunner. A TestRunner runs the generator and calls into the script runner which runs the scripts. This abstraction paves the path for being able to run seed tests without having to run docker.
  • We have 3 commands: seed test to run snapshot tests, seed run to run seed against arbitrary definitions, and seed write-inputs to rewrite inputs like IR / generator Config.
  • Parallelization: if you run seed against a single definition, previously that would go generator by generator. Now, it does all of them at once and respects the parallelization flag.

@dsinghvi dsinghvi changed the title (internal): seed local build mode (internal, seed): heavy rewrite of seed Apr 21, 2024
@dsinghvi dsinghvi marked this pull request as ready for review April 21, 2024 20:19
@dsinghvi dsinghvi force-pushed the dsinghvi/seed-local-build-mode branch from 9254647 to aab965d Compare April 21, 2024 21:12
@dsinghvi dsinghvi merged commit 9c25b33 into main Apr 21, 2024
15 of 18 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/seed-local-build-mode branch April 21, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant