Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat, python: support envvar scanning for headers #3064

Merged
merged 8 commits into from
Feb 26, 2024

Conversation

armandobelardo
Copy link
Contributor

No description provided.

@@ -26,6 +28,7 @@ class SeedAuthEnvironmentVariables:
from seed.client import SeedAuthEnvironmentVariables

client = SeedAuthEnvironmentVariables(
x_another_header="YOUR_X_ANOTHER_HEADER",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@armandobelardo (for the future) we should do something smart in the IR Generation that removes x_ for any headers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for the header name)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's fair, I thought we did it now, but I think it's only for openAPI headers, not ones from Fern defs

Copy link
Member

@dsinghvi dsinghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@armandobelardo armandobelardo merged commit 185a14a into main Feb 26, 2024
14 checks passed
@armandobelardo armandobelardo deleted the ab/pythonheaderenv branch February 26, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants