fix(fastapi): default on pydantic aliases to fix serialization (#4575)

fern-api · Sep 7, 2024 · dcb4059 · dcb4059
1 parent ac52e16
commit dcb4059
Show file tree

Hide file tree

Showing 180 changed files with 831 additions and 1,844 deletions.
diff --git a/.github/workflows/lint-pr.yml b/.github/workflows/lint-pr.yml
@@ -37,6 +37,9 @@ jobs:
             seed
             postman
             ci
+            fastapi
+            spring
+            express
           requireScope: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/generators/python/fastapi/versions.yml b/generators/python/fastapi/versions.yml
@@ -1,4 +1,15 @@
 # For unreleased changes, use unreleased.yml
+- version: 1.4.9
+  ir_version: 53
+  changelog_entry:
+    - type: fix
+      summary: Default on `pydantic aliases`
+      fixed: 
+        - The previous version of the FastAPI generator defaulted on a setting 
+          which removed pydantic aliases. Because FastAPI calls into the 
+          pydantic serializers itself, the generated models must have 
+          aliases. 
+
 - version: 1.4.8
   ir_version: 53
   changelog_entry:

diff --git a/generators/python/src/fern_python/generators/fastapi/custom_config.py b/generators/python/src/fern_python/generators/fastapi/custom_config.py
@@ -11,6 +11,7 @@ class FastApiPydanticModelCustomConfig(BasePydanticModelCustomConfig):
     extra_fields: Optional[Literal["allow", "forbid"]] = "forbid"
     use_str_enums: bool = False
     enum_type: EnumTypes = "python_enums"
+    use_pydantic_field_aliases: bool = True
 
 
 class FastAPICustomConfig(pydantic.BaseModel):

diff --git a/generators/python/src/fern_python/generators/pydantic_model/custom_config.py b/generators/python/src/fern_python/generators/pydantic_model/custom_config.py
@@ -45,7 +45,6 @@ class BasePydanticModelCustomConfig(pydantic.BaseModel):
     ```
     """
 
-    # Defaulted to false for all, then SDK custom config will override
     use_pydantic_field_aliases: bool = False
 
     @pydantic.model_validator(mode="after")

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/seed/fastapi/audiences/resources/foo/service/find_request.py b/seed/fastapi/audiences/resources/foo/service/find_request.py
diff --git a/seed/fastapi/cross-package-type-names/resources/foo/service/find_request.py b/seed/fastapi/cross-package-type-names/resources/foo/service/find_request.py
diff --git a/seed/fastapi/error-property/core/exceptions/fern_http_exception.py b/seed/fastapi/error-property/core/exceptions/fern_http_exception.py
diff --git a/seed/fastapi/examples/resources/commons/resources/types/types/metadata.py b/seed/fastapi/examples/resources/commons/resources/types/types/metadata.py
diff --git a/seed/fastapi/examples/resources/types/types/exception_info.py b/seed/fastapi/examples/resources/types/types/exception_info.py
diff --git a/seed/fastapi/examples/resources/types/types/movie.py b/seed/fastapi/examples/resources/types/types/movie.py
diff --git a/seed/fastapi/examples/resources/types/types/stunt_double.py b/seed/fastapi/examples/resources/types/types/stunt_double.py
diff --git a/...exhaustive/include-validators/resources/inlined_requests/service/post_with_object_body.py b/...exhaustive/include-validators/resources/inlined_requests/service/post_with_object_body.py
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,6 +37,9 @@ jobs: @@
                 seed
                 postman
                 ci
+                fastapi
+                spring
+                express
               requireScope: true
             env:
               GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}