Skip to content

Commit

Permalink
fix(cli): version slugs generate with kebab case (#5163)
Browse files Browse the repository at this point in the history
  • Loading branch information
abvthecity authored Nov 12, 2024
1 parent 34c874b commit 9c555ad
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions packages/cli/cli/versions.yml
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- changelogEntry:
- summary: Fixes bug introduced in 0.45.0-rc33 where version slugs were not being generated correctly.
type: fix
irVersion: 53
version: 0.45.0-rc41

- changelogEntry:
- summary: |
Fixed bug in the Conjure importer where query parameters were overwritten during endpoint parameter parsing.
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/docs-resolver/src/DocsDefinitionResolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ export class DocsDefinitionResolver {
isDefault: boolean
): Promise<FernNavigation.V1.VersionNode> {
const id = this.#idgen.get(version.version);
const slug = parentSlug.setVersionSlug(version.version);
const slug = parentSlug.setVersionSlug(version.slug ?? kebabCase(version.version));
const child =
version.navigation.type === "tabbed"
? await this.convertTabbedNavigation(id, version.navigation.items, slug)
Expand Down

0 comments on commit 9c555ad

Please sign in to comment.