(fix): OpenAPI/AsyncAPI importer handles invalid datetime examples (#…

…3056) (fix): OpenAPI/AsyncAPI importer handles invalid datetimes
fern-api · Feb 26, 2024 · 6cc99e2 · 6cc99e2
1 parent a01dfc4
commit 6cc99e2
Show file tree

Hide file tree

Showing 7 changed files with 12,730 additions and 13 deletions.
diff --git a/packages/cli/openapi-ir-sdk/fern/definition/example.yml b/packages/cli/openapi-ir-sdk/fern/definition/example.yml
@@ -22,9 +22,10 @@ types:
       float: double
       double: double
       string: string
-      datetime: datetime
-      date: date
-      base64: base64
+      # typed as string to handle invalid datetime strings
+      datetime: string
+      date: string
+      base64: string
       boolean: boolean
 
   LiteralExample:

diff --git a/packages/cli/openapi-ir-sdk/src/sdk/api/resources/example/types/PrimitiveExample.ts b/packages/cli/openapi-ir-sdk/src/sdk/api/resources/example/types/PrimitiveExample.ts
@@ -43,7 +43,7 @@ export declare namespace PrimitiveExample {
 
     interface Datetime extends _Utils {
         type: "datetime";
-        value: Date;
+        value: string;
     }
 
     interface Date_ extends _Utils {
@@ -71,7 +71,7 @@ export declare namespace PrimitiveExample {
         float: (value: number) => _Result;
         double: (value: number) => _Result;
         string: (value: string) => _Result;
-        datetime: (value: Date) => _Result;
+        datetime: (value: string) => _Result;
         date: (value: string) => _Result;
         base64: (value: string) => _Result;
         boolean: (value: boolean) => _Result;
@@ -145,7 +145,7 @@ export const PrimitiveExample = {
         };
     },
 
-    datetime: (value: Date): FernOpenapiIr.PrimitiveExample.Datetime => {
+    datetime: (value: string): FernOpenapiIr.PrimitiveExample.Datetime => {
         return {
             value: value,
             type: "datetime",

diff --git a/...ages/cli/openapi-ir-sdk/src/sdk/serialization/resources/example/types/PrimitiveExample.ts b/...ages/cli/openapi-ir-sdk/src/sdk/serialization/resources/example/types/PrimitiveExample.ts
@@ -27,7 +27,7 @@ export const PrimitiveExample: core.serialization.Schema<
             value: core.serialization.string(),
         }),
         datetime: core.serialization.object({
-            value: core.serialization.date(),
+            value: core.serialization.string(),
         }),
         date: core.serialization.object({
             value: core.serialization.string(),

diff --git a/packages/cli/openapi-ir-to-fern/src/buildEndpointExample.ts b/packages/cli/openapi-ir-to-fern/src/buildEndpointExample.ts
@@ -169,7 +169,7 @@ function convertPrimitive(primitiveExample: PrimitiveExample): RawSchemas.Exampl
         case "datetime":
             try {
                 // remove milliseconds from the datetime
-                return primitiveExample.value.toISOString().replace(/\.\d{3}Z$/, "Z");
+                return new Date(primitiveExample.value).toISOString().replace(/\.\d{3}Z$/, "Z");
             } catch (e) {
                 return "2024-01-15T09:30:00Z";
             }

diff --git a/packages/cli/openapi-ir-to-fern/src/buildWebsocketSessionExample.ts b/packages/cli/openapi-ir-to-fern/src/buildWebsocketSessionExample.ts
@@ -142,7 +142,7 @@ function convertPrimitive(primitiveExample: PrimitiveExample): RawSchemas.Exampl
         case "datetime":
             try {
                 // remove milliseconds from the datetime
-                return primitiveExample.value.toISOString().replace(/\.\d{3}Z$/, "Z");
+                return new Date(primitiveExample.value).toISOString().replace(/\.\d{3}Z$/, "Z");
             } catch (e) {
                 return "2024-01-15T09:30:00Z";
             }