fix(typescript): Don't double check whether an optional string litera…

…l alias is a string when using serializer to build query string parameters. (#5614)

* fix(typescript): Don't double check whether an optional string literal alias is a string when using serializer to build query string parameters

generators/typescript/model/type-reference-converters/src/TypeReferenceToStringExpressionConverter.ts

@@ -81,7 +81,12 @@ export class TypeReferenceToStringExpressionConverter extends AbstractTypeRefere
                                 optional: (optional) => getStringify(this.context.type.resolveTypeReference(optional)),
                                 set: () => this.jsonStringify(mapExpression),
                                 map: () => this.jsonStringify(mapExpression),
-                                literal: () => this.jsonStringifyIfNotString(mapExpression),
+                                literal: (literal) => {
+                                    if (literal.type === "string") {
+                                        return mapExpression;
+                                    }
+                                    return this.jsonStringify(mapExpression);
+                                },
                                 _other: () => {
                                     throw new Error("Unknown ContainerType: " + containerType.type);
                                 }

generators/typescript/sdk/CHANGELOG.md

@@ -5,7 +5,46 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.46.10] - 2025-01-13
+## [0.46.11] - 2025-01-14
+
+- Fix: Don't double check whether an optional string literal alias (see example below) is a string when using serializer to build query string parameters.
+
+  ```yml
+  types:
+    LiteralAliasExample: literal<"MyLiteralValue">
+
+  service:
+    endpoints:
+      foo:
+        path: /bar
+        method: POST
+        request:
+          name: FooBarRequest
+          query-parameters:
+            optional_alias_literal: optional<LiteralAliasExample>
+  ```
+
+  ```ts
+  // before
+  if (optionalAliasLiteral != null) {
+      _queryParams["optional_alias_literal"] = typeof serializers.LiteralAliasExample.jsonOrThrow(optionalAliasLiteral, {
+          unrecognizedObjectKeys: "strip",
+      }) === "string" ? serializers.LiteralAliasExample.jsonOrThrow(optionalAliasLiteral, {
+          unrecognizedObjectKeys: "strip",
+      }) : JSON.stringify(serializers.LiteralAliasExample.jsonOrThrow(optionalAliasLiteral, {
+          unrecognizedObjectKeys: "strip",
+      }));
+  }
+
+  // after
+  if (optionalAliasLiteral != null) {
+      _queryParams["optional_alias_literal"] = serializers.LiteralAliasExample.jsonOrThrow(optionalAliasLiteral, {
+          unrecognizedObjectKeys: "strip",
+      });
+  }
+  ```
+
+## [0.46.10] - 2025-01-14
 
 - Fix: Use serialization layer to convert types to JSON strings when enabled.
 

generators/typescript/sdk/VERSION

@@ -1 +1 @@
-0.46.10
+0.46.11