fix: perform the correct null check on headers (#3571)

fern-api · May 8, 2024 · 62fc4a2 · 62fc4a2
1 parent 09219e7
commit 62fc4a2
Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/generators/java/sdk/CHANGELOG.md b/generators/java/sdk/CHANGELOG.md
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.8.11] - 2024-05-08
+
+- Fix: Corrects the fix in 0.8.10 to check null value as opposed to a .isPresent check, given the header is not `Optional`, it's always `String`
+
 ## [0.8.10] - 2024-05-08
 
 - Fix: Fixes regression from 0.8.8, headers are no longer added to the header map unless they are non-null.

diff --git a/generators/java/sdk/VERSION b/generators/java/sdk/VERSION
@@ -1 +1 @@
-0.8.10
+0.8.11
diff --git a/generators/java/sdk/src/main/java/com/fern/java/client/generators/RootClientGenerator.java b/generators/java/sdk/src/main/java/com/fern/java/client/generators/RootClientGenerator.java
@@ -389,7 +389,7 @@ public Void visitHeaderBase(HeaderAuthScheme header, Boolean respectMandatoryAut
             // If the header is optional, wrap the add in a presence check so it does not get added unless it's non-null
             if (shouldWrapInConditional) {
                 maybeConditionalAdditionFlow = this.buildMethod
-                        .beginControlFlow("if ($L.isPresent())", fieldName);
+                        .beginControlFlow("if ($L != null)", fieldName);
             }
 
             if (header.getPrefix().isPresent()) {

diff --git a/seed/java-sdk/exhaustive/no-custom-config/.inputs/config.json b/seed/java-sdk/exhaustive/no-custom-config/.inputs/config.json
diff --git a/seed/java-sdk/trace/src/main/java/com/seed/trace/SeedTraceClientBuilder.java b/seed/java-sdk/trace/src/main/java/com/seed/trace/SeedTraceClientBuilder.java