(fix, cli): remove out of range number validations in `openapi-ir-to-…

…fern` + remove husky (#3948)
fern-api · Jun 27, 2024 · 390b735 · 390b735
1 parent f68ab7e
commit 390b735
Show file tree

Hide file tree

Showing 13 changed files with 97 additions and 77 deletions.
diff --git a/.husky/post-checkout b/.husky/post-checkout
diff --git a/.husky/pre-commit b/.husky/pre-commit
diff --git a/.pnp.cjs b/.pnp.cjs
diff --git a/.yarn/cache/husky-npm-8.0.1-85fede8470-943a73a13d.zip b/.yarn/cache/husky-npm-8.0.1-85fede8470-943a73a13d.zip
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -63,10 +63,6 @@ yarn
 
 This tells VSCode to rely on the version of TypeScript that lives in `.yarn/sdks/typescript`, which is modified to work with Yarn PNP.
 
-**Step 5: Install Husky**
-
-Run `yarn husky install` from the root of the repo and this will configure pre-commit hooks that will lint your changes.
-
 ### Compiling
 
 To compile the packages in this monorepo, run `yarn compile`.

diff --git a/package.json b/package.json
@@ -74,7 +74,6 @@
     "eslint-plugin-react-hooks": "^4.6.0",
     "eslint-plugin-tailwindcss": "^3.15.1",
     "execa": "^5.1.1",
-    "husky": "^8.0.1",
     "immer": "^9.0.15",
     "is-ci": "^3.0.1",
     "jest": "^29.7.0",

diff --git a/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/aries.test.ts.snap b/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/aries.test.ts.snap
@@ -18770,7 +18770,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -18782,7 +18782,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -18986,7 +18986,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -19073,7 +19073,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -19085,7 +19085,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -19126,7 +19126,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -19138,7 +19138,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -19218,7 +19218,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -19230,7 +19230,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -19365,7 +19365,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -21105,7 +21105,7 @@ exports[`open api parser aries docs 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -41856,7 +41856,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -41868,7 +41868,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42072,7 +42072,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42159,7 +42159,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42171,7 +42171,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42212,7 +42212,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42224,7 +42224,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42304,7 +42304,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42316,7 +42316,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -42451,7 +42451,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },
@@ -44191,7 +44191,7 @@ exports[`open api parser aries simple 1`] = `
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 18446744073709552000,
+              "max": undefined,
               "min": 0,
               "multipleOf": undefined,
             },

diff --git a/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/belvo.test.ts.snap b/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/belvo.test.ts.snap
@@ -10101,7 +10101,7 @@ During the payment intent flow, you need to fill in the payment intent with requ
               "validation": {
                 "exclusiveMax": undefined,
                 "exclusiveMin": undefined,
-                "max": 9999999999,
+                "max": undefined,
                 "min": 1,
                 "multipleOf": undefined,
               },
@@ -23333,7 +23333,7 @@ In our documentation example, we use \`{endpoint}\` as a placeholder value. In p
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 9999999999,
+              "max": undefined,
               "min": 1,
               "multipleOf": undefined,
             },
@@ -43491,7 +43491,7 @@ During the payment intent flow, you need to fill in the payment intent with requ
               "validation": {
                 "exclusiveMax": undefined,
                 "exclusiveMin": undefined,
-                "max": 9999999999,
+                "max": undefined,
                 "min": 1,
                 "multipleOf": undefined,
               },
@@ -55348,7 +55348,7 @@ In our documentation example, we use \`{endpoint}\` as a placeholder value. In p
             "validation": {
               "exclusiveMax": undefined,
               "exclusiveMin": undefined,
-              "max": 9999999999,
+              "max": undefined,
               "min": 1,
               "multipleOf": undefined,
             },

diff --git a/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/rules.test.ts.snap b/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/rules.test.ts.snap
@@ -16,6 +16,7 @@ exports[`rules rules docs 1`] = `
             {
               "response": {
                 "body": {
+                  "age": 1,
                   "id": 1,
                   "name": "name",
                   "value": 1.1,
@@ -51,6 +52,18 @@ exports[`rules rules docs 1`] = `
       "Schema": {
         "docs": undefined,
         "properties": {
+          "age": {
+            "default": 50,
+            "docs": "The age of the type.",
+            "type": "optional<integer>",
+            "validation": {
+              "exclusiveMax": false,
+              "exclusiveMin": true,
+              "max": undefined,
+              "min": undefined,
+              "multipleOf": 10,
+            },
+          },
           "id": {
             "default": 50,
             "docs": "The unique ID of the type.",
@@ -125,6 +138,7 @@ exports[`rules rules simple 1`] = `
             {
               "response": {
                 "body": {
+                  "age": 1,
                   "id": 1,
                   "name": "name",
                   "value": 1.1,
@@ -160,6 +174,18 @@ exports[`rules rules simple 1`] = `
       "Schema": {
         "docs": undefined,
         "properties": {
+          "age": {
+            "default": 50,
+            "docs": "The age of the type.",
+            "type": "optional<integer>",
+            "validation": {
+              "exclusiveMax": false,
+              "exclusiveMin": true,
+              "max": undefined,
+              "min": undefined,
+              "multipleOf": 10,
+            },
+          },
           "id": {
             "default": 50,
             "docs": "The unique ID of the type.",

diff --git a/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/uploadcare.test.ts.snap b/packages/cli/openapi-ir-to-fern/src/__test__/__snapshots__/uploadcare.test.ts.snap
@@ -2378,7 +2378,7 @@ to us as a value of the \`part_size\` parameter (in bytes).
                     "validation": {
                       "exclusiveMax": undefined,
                       "exclusiveMin": undefined,
-                      "max": 5368709120,
+                      "max": undefined,
                       "min": 5242880,
                       "multipleOf": undefined,
                     },
@@ -6846,7 +6846,7 @@ to us as a value of the \`part_size\` parameter (in bytes).
                     "validation": {
                       "exclusiveMax": undefined,
                       "exclusiveMin": undefined,
-                      "max": 5368709120,
+                      "max": undefined,
                       "min": 5242880,
                       "multipleOf": undefined,
                     },

diff --git a/packages/cli/openapi-ir-to-fern/src/__test__/fixtures/rules/openapi.yml b/packages/cli/openapi-ir-to-fern/src/__test__/fixtures/rules/openapi.yml
@@ -39,6 +39,15 @@ components:
           exclusiveMinimum: true
           exclusiveMaximum: false
           multipleOf: 10
+        age:
+          description: The age of the type.
+          type: integer
+          default: 50
+          minimum: -2147483649 # outside of min int
+          maximum: 2147483648 # outside of max int
+          exclusiveMinimum: true
+          exclusiveMaximum: false
+          multipleOf: 10
         name:
           description: The unique name of the type.
           type: string