Skip to content

Commit

Permalink
(feat, docs): send status code to fdr (#3582)
Browse files Browse the repository at this point in the history
  • Loading branch information
dsinghvi authored May 9, 2024
1 parent 23b1f5b commit 08a85c2
Show file tree
Hide file tree
Showing 9 changed files with 30 additions and 27 deletions.
16 changes: 8 additions & 8 deletions .pnp.cjs

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file not shown.
2 changes: 1 addition & 1 deletion packages/cli/configuration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"dependencies": {
"@fern-api/core-utils": "workspace:*",
"@fern-api/fdr-sdk": "0.91.1-5ff5ffb15",
"@fern-api/fdr-sdk": "0.93.0-665149116",
"@fern-api/fs-utils": "workspace:*",
"@fern-api/task-context": "workspace:*",
"@fern-fern/fiddle-sdk": "^0.0.532",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/docs-preview/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"dependencies": {
"@fern-api/configuration": "workspace:*",
"@fern-api/core-utils": "workspace:*",
"@fern-api/fdr-sdk": "0.91.1-5ff5ffb15",
"@fern-api/fdr-sdk": "0.93.0-665149116",
"@fern-api/fs-utils": "workspace:*",
"@fern-api/ir-generator": "workspace:*",
"@fern-api/register": "workspace:*",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@fern-api/core": "workspace:*",
"@fern-api/core-utils": "workspace:*",
"@fern-api/docs-validator": "workspace:*",
"@fern-api/fdr-sdk": "0.91.1-5ff5ffb15",
"@fern-api/fdr-sdk": "0.93.0-665149116",
"@fern-api/fs-utils": "workspace:*",
"@fern-api/ir-generator": "workspace:*",
"@fern-api/ir-migrations": "workspace:*",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/register/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@fern-api/configuration": "workspace:*",
"@fern-api/core": "workspace:*",
"@fern-api/core-utils": "workspace:*",
"@fern-api/fdr-sdk": "0.91.1-5ff5ffb15",
"@fern-api/fdr-sdk": "0.93.0-665149116",
"@fern-api/ir-generator": "workspace:*",
"@fern-api/ir-sdk": "workspace:*",
"@fern-api/task-context": "workspace:*",
Expand Down
13 changes: 8 additions & 5 deletions packages/cli/register/src/ir-to-fdr-converter/convertPackage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function convertService(
})
),
request: irEndpoint.requestBody != null ? convertRequestBody(irEndpoint.requestBody) : undefined,
response: irEndpoint.response?.body != null ? convertResponse(irEndpoint.response.body) : undefined,
response: irEndpoint.response != null ? convertResponse(irEndpoint.response) : undefined,
errors: undefined,
errorsV2: convertResponseErrorsV2(irEndpoint.errors, ir),
examples: irEndpoint.examples
Expand Down Expand Up @@ -388,8 +388,11 @@ function convertRequestBody(irRequest: Ir.http.HttpRequestBody): APIV1Write.Http
return requestBodyShape != null ? { type: requestBodyShape } : undefined;
}

function convertResponse(irResponse: Ir.http.HttpResponseBody): APIV1Write.HttpResponse | undefined {
const type = Ir.http.HttpResponseBody._visit<APIV1Write.HttpResponseBodyShape | undefined>(irResponse, {
function convertResponse(irResponse: Ir.http.HttpResponse): APIV1Write.HttpResponse | undefined {
if (irResponse.body == null) {
return undefined;
}
const type = Ir.http.HttpResponseBody._visit<APIV1Write.HttpResponseBodyShape | undefined>(irResponse.body, {
fileDownload: () => {
return {
type: "fileDownload"
Expand Down Expand Up @@ -423,11 +426,11 @@ function convertResponse(irResponse: Ir.http.HttpResponseBody): APIV1Write.HttpR
return undefined;
},
_other: () => {
throw new Error("Unknown HttpResponse: " + irResponse.type);
throw new Error("Unknown HttpResponse: " + irResponse.body);
}
});
if (type != null) {
return { type };
return { type, statusCode: irResponse.statusCode };
} else {
return undefined;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"depcheck": "depcheck"
},
"dependencies": {
"@fern-api/fdr-sdk": "0.91.1-5ff5ffb15",
"@fern-api/fdr-sdk": "0.93.0-665149116",
"@fern-api/venus-api-sdk": "0.0.38",
"@fern-fern/fdr-test-sdk": "^0.0.5297",
"@fern-fern/fiddle-sdk": "^0.0.532"
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3448,7 +3448,7 @@ __metadata:
resolution: "@fern-api/configuration@workspace:packages/cli/configuration"
dependencies:
"@fern-api/core-utils": "workspace:*"
"@fern-api/fdr-sdk": 0.91.1-5ff5ffb15
"@fern-api/fdr-sdk": 0.93.0-665149116
"@fern-api/fs-utils": "workspace:*"
"@fern-api/task-context": "workspace:*"
"@fern-fern/fiddle-sdk": ^0.0.532
Expand Down Expand Up @@ -3492,7 +3492,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@fern-api/core@workspace:packages/core"
dependencies:
"@fern-api/fdr-sdk": 0.91.1-5ff5ffb15
"@fern-api/fdr-sdk": 0.93.0-665149116
"@fern-api/venus-api-sdk": 0.0.38
"@fern-fern/fdr-test-sdk": ^0.0.5297
"@fern-fern/fiddle-sdk": ^0.0.532
Expand Down Expand Up @@ -3555,7 +3555,7 @@ __metadata:
dependencies:
"@fern-api/configuration": "workspace:*"
"@fern-api/core-utils": "workspace:*"
"@fern-api/fdr-sdk": 0.91.1-5ff5ffb15
"@fern-api/fdr-sdk": 0.93.0-665149116
"@fern-api/fs-utils": "workspace:*"
"@fern-api/ir-generator": "workspace:*"
"@fern-api/register": "workspace:*"
Expand Down Expand Up @@ -3629,9 +3629,9 @@ __metadata:
languageName: unknown
linkType: soft

"@fern-api/fdr-sdk@npm:0.91.1-5ff5ffb15":
version: 0.91.1-5ff5ffb15
resolution: "@fern-api/fdr-sdk@npm:0.91.1-5ff5ffb15"
"@fern-api/fdr-sdk@npm:0.93.0-665149116":
version: 0.93.0-665149116
resolution: "@fern-api/fdr-sdk@npm:0.93.0-665149116"
dependencies:
form-data: 4.0.0
js-base64: 3.7.7
Expand All @@ -3641,7 +3641,7 @@ __metadata:
qs: 6.12.0
tinycolor2: ^1.6.0
url-join: 4.0.1
checksum: cd1024a52f149ce2b8c603154dbbfb144b8f7590fc8a4187a33d4b506f82d7bc86e08d6352a1876e7709fd0945b6a87fcf482b0dbe263fc9f9be630a628ad0a9
checksum: ec318a2b006ef95bdf0af8aa6a66c97eff39c7b6b385aa933818d5f0e5a082d82a24d5580bcb754aaea63fd9bee1c016ba860c8244b46cefe54e7ff97e2afce3
languageName: node
linkType: hard

Expand Down Expand Up @@ -4278,7 +4278,7 @@ __metadata:
"@fern-api/configuration": "workspace:*"
"@fern-api/core": "workspace:*"
"@fern-api/core-utils": "workspace:*"
"@fern-api/fdr-sdk": 0.91.1-5ff5ffb15
"@fern-api/fdr-sdk": 0.93.0-665149116
"@fern-api/ir-generator": "workspace:*"
"@fern-api/ir-sdk": "workspace:*"
"@fern-api/task-context": "workspace:*"
Expand All @@ -4305,7 +4305,7 @@ __metadata:
"@fern-api/core": "workspace:*"
"@fern-api/core-utils": "workspace:*"
"@fern-api/docs-validator": "workspace:*"
"@fern-api/fdr-sdk": 0.91.1-5ff5ffb15
"@fern-api/fdr-sdk": 0.93.0-665149116
"@fern-api/fs-utils": "workspace:*"
"@fern-api/ir-generator": "workspace:*"
"@fern-api/ir-migrations": "workspace:*"
Expand Down

0 comments on commit 08a85c2

Please sign in to comment.