Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: add example id to snippet and to search #904

Merged
merged 9 commits into from
May 23, 2024
Merged

Conversation

armandobelardo
Copy link
Contributor

Fixes FER-1809

Short description of the changes made

This PR adds example ID to the snippets and a way to filter to it

What was the motivation & context behind this PR?

We need a way to distinguish which example is behind which snippet to be able to display things differently

@armandobelardo armandobelardo requested a review from dsinghvi as a code owner May 22, 2024 22:01
Copy link

linear bot commented May 22, 2024

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ✅ Ready (Inspect) Visit Preview May 23, 2024 10:13am
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) May 23, 2024 10:13am
fontawesome-cdn ⬜️ Ignored (Inspect) May 23, 2024 10:13am
private-docs ⬜️ Ignored (Inspect) May 23, 2024 10:13am

Copy link

Copy link

Copy link

@dsinghvi
Copy link
Member

I think to complete the goal here we will need to update the Read API Definition (link) to contain snippets that are keyed by example

Copy link

Copy link

Copy link

@armandobelardo armandobelardo requested a review from dsinghvi May 23, 2024 00:00
Copy link

Copy link

@dsinghvi dsinghvi merged commit e2a734a into main May 23, 2024
20 checks passed
@dsinghvi dsinghvi deleted the ab/FER-1809 branch May 23, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants