Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): add AnyPrincipal for local preview bundle #885

Merged
merged 2 commits into from
May 16, 2024

Conversation

dsinghvi
Copy link
Member

Short description of the changes made

This PR baches 2 AWS infra changes:

  • adds a principal to the iam role for local bundles
  • allow-lists public s3 domains

What was the motivation & context behind this PR?

An effort to improve image performance

How has this PR been tested?

Will be test on dev stack

@dsinghvi dsinghvi requested a review from abvthecity as a code owner May 16, 2024 22:36
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ✅ Ready (Inspect) Visit Preview May 16, 2024 10:36pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) May 16, 2024 10:36pm
fontawesome-cdn ⬜️ Ignored (Inspect) May 16, 2024 10:36pm
private-docs ⬜️ Ignored (Inspect) May 16, 2024 10:36pm

@dsinghvi dsinghvi changed the title (fix): add AnyPrincipal (fix): add AnyPrincipal for local preview bundle May 16, 2024
@dsinghvi dsinghvi merged commit d688576 into main May 16, 2024
19 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/fix-local-preview-bundle branch May 16, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant