Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add in the IR endpoint identifier (optionally) to have a more unique id #881

Merged
merged 8 commits into from
May 17, 2024

Conversation

armandobelardo
Copy link
Contributor

Fixes FER-1739

Currently our snippets get conflicted when you have two different SDK functions working off of the same endpoint method and path (think GET /chat which supports stream and non-stream), we do this for streaming endpoints (a lot for chat complete with AI companies), and it's really easy to do with a fern definition.

This PR as well as the one in Fiddle (https://github.com/fern-api/fiddle/pull/379) optionally add in the endpoint ID from the IR, which is unique, and swap filtering and selecting snippets to leverage this ID where possible

This will also require generator changes

Copy link

linear bot commented May 16, 2024

FER-1739 [OctoAI, MultiOn] Streaming + non streaming code snippets correctly matched up by FDR

Today FDR matches by method and path name, but streaming/non-streaming endpoints have the same method and path name. We'll need to add some more data to the snippets so that FDR can match correctly.

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ✅ Ready (Inspect) Visit Preview May 17, 2024 10:20am
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) May 17, 2024 10:20am
fontawesome-cdn ⬜️ Ignored (Inspect) May 17, 2024 10:20am
private-docs ⬜️ Ignored (Inspect) May 17, 2024 10:20am

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

@armandobelardo armandobelardo changed the title wip, fix: add in the IR endpoint identifier (optionally) to have a more unique id fix: add in the IR endpoint identifier (optionally) to have a more unique id May 17, 2024
@armandobelardo armandobelardo enabled auto-merge (squash) May 17, 2024 10:15
Copy link

@armandobelardo armandobelardo merged commit cb0d2d2 into main May 17, 2024
22 checks passed
@armandobelardo armandobelardo deleted the ab/FER-1739 branch May 17, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants