(fix, fdr): create a public S3 bucket so that we can share images without public presigned urls #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dsinghvi
commented
May 15, 2024
| }, | ||
| versioned: true, | ||
| }); | ||
| publicBucket.grantPublicAccess(); |
There was a problem hiding this comment.
We create a new public S3 bucket here
dsinghvi
commented
May 15, 2024
| bucketName: getEnvironmentVariableOrThrow(PRIVATE_S3_BUCKET_NAME_ENV_VAR), | ||
| bucketRegion: getEnvironmentVariableOrThrow(PRIVATE_S3_BUCKET_REGION_ENV_VAR), | ||
| urlOverride: process.env.PRIVATE_S3_URL_OVERRIDE_ENV_VAR, | ||
| }, |
There was a problem hiding this comment.
the public and private s3 bucket URL information is parsed here
abvthecity
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes made
This PR creates a public S3 bucket so that we can start storing assets for public docs in this S3 bucket.
What was the motivation & context behind this PR?
How has this PR been tested?
[pending]