Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Respect content size on mobile header #864

Conversation

KenzoBenzo
Copy link
Contributor

@KenzoBenzo KenzoBenzo commented May 14, 2024

Fixes FER-1700

Short description of the changes made

On mobile, our header height is now based on wether tabs are shown or not

OctoAI

Before After
Before After

Fern

Before After
Before After

What was the motivation & context behind this PR?

Fern and OctoAI both had mobile navigation issues.

How has this PR been tested?

  • Fern locally
  • Octo locally
  • Hume preview (not using tabs)

@KenzoBenzo KenzoBenzo self-assigned this May 14, 2024
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ✅ Ready (Inspect) Visit Preview May 14, 2024 11:01pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) May 14, 2024 11:01pm
fontawesome-cdn ⬜️ Ignored (Inspect) May 14, 2024 11:01pm
private-docs ⬜️ Ignored (Inspect) May 14, 2024 11:01pm

@KenzoBenzo KenzoBenzo marked this pull request as ready for review May 14, 2024 22:58
@KenzoBenzo KenzoBenzo requested a review from abvthecity as a code owner May 14, 2024 22:58
@KenzoBenzo KenzoBenzo enabled auto-merge (squash) May 14, 2024 23:23
@KenzoBenzo KenzoBenzo merged commit 0a951ca into main May 14, 2024
19 checks passed
@KenzoBenzo KenzoBenzo deleted the makenna/fer-1700-octoai-styling-bug-tabs-are-hiding-the-searchbar-in-mobile branch May 14, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants