fix & document: Dropdown component #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FER-1462 Dropdown
If the accent primary is dark then it hides the actual enum docs Screenshot 2024-05-01 at 3.51.07 PM.png
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abvthecity
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FER-1462 — THIS DOES NOT FIX THE TOOLTIP BUG FER-1535 YET
Short description of the changes made
Updated the layout of the dropdown component + fixed a usage bug.
Before
After
What was the motivation & context behind this PR?
The design had low hanging fruit to look better + a ~bug in production.
How has this PR been tested?