fix: Serializing of body params correctly sequences checks before aborting #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FER-1675 API playground isn't sending a body in some instances
Definitely affecting POST requests and STREAM |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abvthecity
approved these changes
May 9, 2024
worked for stream as well (on octo)
|
abvthecity
deleted the
makenna/fer-1675-api-playground-isnt-sending-a-body-in-some-instances
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FER-1675
Short description of the changes made
Move the check for formData into the nested relevant case. This means we don't return undefined almost no matter what now.
What was the motivation & context behind this PR?
Almost every request needing a
bodyparam in prod is currently broken on the API playground.How has this PR been tested?
Using the API playground on: