Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if layout width is NaN, avoid throwing #761

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented May 1, 2024

user-inputted props need more validation; a NaN here happens to throw an error and wipe out the page.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
fern-dev ✅ Ready (Inspect) Visit Preview May 1, 2024 8:13pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
fern-prod ⬜️ Ignored (Inspect) May 1, 2024 8:13pm
fontawesome-cdn ⬜️ Ignored (Inspect) May 1, 2024 8:13pm
private-docs ⬜️ Ignored (Inspect) May 1, 2024 8:13pm

@abvthecity abvthecity merged commit 54c326b into main May 1, 2024
19 checks passed
@abvthecity abvthecity deleted the ajiang/fix-image-nan branch May 1, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants