Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openrpc): parse methods into fdr latest endpoints #2003

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

dsinghvi
Copy link
Member

Short description of the changes made

This PR updates the openrpc parser to parse methods.

What was the motivation & context behind this PR?

Customer demand.

How has this PR been tested?

Snapshot test

@dsinghvi dsinghvi marked this pull request as ready for review January 14, 2025 00:38
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 14, 2025 0:38am
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 14, 2025 0:38am

@@ -80,7 +80,188 @@
}
}
},
"endpoints": {},
"endpoints": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proof that it works

Copy link

github-actions bot commented Jan 14, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 14, 2025

PR Preview

Copy link

github-actions bot commented Jan 14, 2025

Playwright test results

passed  98 passed
flaky  1 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  1 minute, 15 seconds
commit  2398860

Flaky tests

chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

const requestParameters: FernRegistry.api.latest.ObjectProperty[] =
resolvedParams
?.map((param): FernRegistry.api.latest.ObjectProperty | undefined => {
const schema = new SchemaConverterNode({
Copy link
Member

@RohinBhargava RohinBhargava Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that there are some opportunities to make sure that we capture all parts of the relevant input here, in the parse function, according to https://spec.open-rpc.org/#method-object. If this works sufficiently for our design partner, will make a note to refactor this later, however

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense -- im going to ignore this for now due to velocity but hear you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants