-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openrpc): parse methods into fdr latest endpoints #2003
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@@ -80,7 +80,188 @@ | |||
} | |||
} | |||
}, | |||
"endpoints": {}, | |||
"endpoints": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proof that it works
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Playwright test resultsDetails 101 tests across 9 suites Flaky testschromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
const requestParameters: FernRegistry.api.latest.ObjectProperty[] = | ||
resolvedParams | ||
?.map((param): FernRegistry.api.latest.ObjectProperty | undefined => { | ||
const schema = new SchemaConverterNode({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that there are some opportunities to make sure that we capture all parts of the relevant input here, in the parse function, according to https://spec.open-rpc.org/#method-object. If this works sufficiently for our design partner, will make a note to refactor this later, however
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense -- im going to ignore this for now due to velocity but hear you
Short description of the changes made
This PR updates the openrpc parser to parse methods.
What was the motivation & context behind this PR?
Customer demand.
How has this PR been tested?
Snapshot test