Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Global headers and better enum parsing in OpenApi Parser v2 #1995

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • Adds reference resolving to enum parsing. Enums are distinctly different from anyOf/oneOf in that they are not multiplexed
  • Adds global header parsing

What was the motivation & context behind this PR?

  • Customer need

How has this PR been tested?

  • Snapshot tests
  • Unit tests

Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Jan 13, 2025 5:04pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Jan 13, 2025 5:04pm

Copy link

github-actions bot commented Jan 13, 2025

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Jan 13, 2025

PR Preview

Copy link

github-actions bot commented Jan 13, 2025

Playwright test results

passed  98 passed
flaky  1 flaky
skipped  2 skipped

Details

stats  101 tests across 9 suites
duration  58.6 seconds
commit  40edcf2

Flaky tests

chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › websockets/websocket.spec.ts › websocket test

@RohinBhargava RohinBhargava marked this pull request as ready for review January 13, 2025 20:56
@RohinBhargava RohinBhargava merged commit 4520edf into main Jan 14, 2025
16 of 17 checks passed
@RohinBhargava RohinBhargava deleted the rohin/better-enum-parsing-openapi-parser-v2 branch January 14, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants