-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: FDR Latest pulling at the edge (S3 upload/download) #1994
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
🌿 Preview your docs: https://fern-preview-c8c7e24c-ad09-449e-88c7-97d80b1d5675.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-4f6ba162-2087-4f89-adf0-c97f478c3531.docs.buildwithfern.com |
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Playwright test resultsDetails 101 tests across 9 suites Flaky testschromium › forward-proxy/express.spec.ts › home page 404 Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
🌿 Preview your docs: https://fern-preview-63fccc1f-e901-4e5d-a736-1903f9f2d0e6.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-63c12ca5-83b7-4130-abd2-3943bf01444c.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-e128101d-3eff-4842-9bf6-d38be5388d6a.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-3c991263-19b0-45a5-9018-c6ffd12a7522.docs.buildwithfern.com |
🌿 Preview your docs: https://fern-preview-983525e0-6040-4929-bb68-60292249d171.docs.buildwithfern.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a large PR, but this makes sense to me
Short description of the changes made
This change introduces pulling FDR Latest specs directly from S3, using already existing S3 asset buckets. The reason we can do this is because we no longer have shape transformations for FDR docs shapes, and instead have one shape that is registered and read.
This PR chooses to use FDR to upload S3 specs, however, this can easily be moved into the CLI (before this, there should be a discussion of security concerns of distributing S3 keys to clients/this is not an issue in Next since the api keys are used in the backend part of next). For spec pulling, this is done directly at the site that needs the data (some FDR apis or edge functions, because we need to index algolia records).
*The idea is that this should improve performance, since we see that FDR is a current bottleneck, and that there is one less hop to deliver the data to the end user.
THIS NEEDS TO BE THOROUGHLY TESTED
What was the motivation & context behind this PR?
How has this PR been tested?