Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devx: speed up organize imports #1929

Merged
merged 5 commits into from
Dec 21, 2024
Merged

devx: speed up organize imports #1929

merged 5 commits into from
Dec 21, 2024

Conversation

abvthecity
Copy link
Contributor

the organize imports code action is causing huge performance issues on vscode. switching to prettier is much faster.

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Dec 20, 2024 11:55pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Dec 20, 2024 11:55pm

@abvthecity abvthecity marked this pull request as ready for review December 20, 2024 23:55
@abvthecity abvthecity enabled auto-merge (squash) December 20, 2024 23:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 219.63 KB (🟢 -724 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

PR Preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 21, 2024 •
edited
Loading

Playwright test results

passed  97 passed
flaky  2 flaky
skipped  4 skipped

Details

stats  103 tests across 10 suites
duration  1 minute, 36 seconds
commit  ced788b

Flaky tests

chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.aiaplatform.com.au

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request
chromium › websockets/websocket.spec.ts › websocket test

@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com December 21, 2024 00:16 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com December 21, 2024 00:16 — with GitHub Actions Error
@abvthecity abvthecity disabled auto-merge December 21, 2024 01:23
@dannysheridan dannysheridan merged commit a66df3d into main Dec 21, 2024
17 of 19 checks passed
@dannysheridan dannysheridan deleted the ajiang/fix-organize-imports branch December 21, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannysheridan dannysheridan dannysheridan approved these changes

@dsinghvi dsinghvi dsinghvi approved these changes

@RohinBhargava RohinBhargava Awaiting requested review from RohinBhargava RohinBhargava is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abvthecity @dsinghvi @dannysheridan