Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr=true for feedback provider to avoid ssr issues on fern's docs #1928

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

abvthecity
Copy link
Contributor

FeedbackProvider ssr=false is causing the page to not load.

@abvthecity abvthecity marked this pull request as ready for review December 20, 2024 23:30
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Dec 20, 2024 11:30pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Dec 20, 2024 11:30pm

@abvthecity abvthecity enabled auto-merge (squash) December 20, 2024 23:30
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com December 20, 2024 23:30 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com December 20, 2024 23:30 — with GitHub Actions Error
Copy link

github-actions bot commented Dec 20, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

@abvthecity abvthecity merged commit 64fc9b3 into main Dec 20, 2024
16 of 17 checks passed
@abvthecity abvthecity deleted the ajiang/fix-dynamic-ssr branch December 20, 2024 23:45
Copy link

Playwright test results

passed  98 passed
flaky  1 flaky
skipped  4 skipped

Details

stats  103 tests across 10 suites
duration  49.6 seconds
commit  7bc22ee

Flaky tests

chromium › skew-protection/index.test.ts › should contain ?dpl= or x-deployment-id header on all scripts and prefetch requests

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request
chromium › websockets/websocket.spec.ts › websocket test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants