Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix api playground that was short circuiting too early #1916

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • API latest was short circuiting the api resolution too early

What was the motivation & context behind this PR?

  • Playground not loading during testing

How has this PR been tested?

  • To be tested during FDR dev

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Dec 19, 2024 6:15pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Dec 19, 2024 6:15pm

@RohinBhargava RohinBhargava had a problem deploying to Preview - app-dev.buildwithfern.com December 19, 2024 18:16 — with GitHub Actions Error
@RohinBhargava RohinBhargava had a problem deploying to Preview - app.buildwithfern.com December 19, 2024 18:16 — with GitHub Actions Error
Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

Copy link

github-actions bot commented Dec 19, 2024

Playwright test results

passed  97 passed
flaky  2 flaky
skipped  4 skipped

Details

stats  103 tests across 10 suites
duration  51 seconds
commit  426ca18

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › redirect

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request
chromium › websockets/websocket.spec.ts › websocket test

@RohinBhargava RohinBhargava merged commit 4f8db4d into main Dec 19, 2024
16 of 17 checks passed
@RohinBhargava RohinBhargava deleted the rohin/patch-fdr-playground branch December 19, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants