Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve searchbar colors #1871

Merged
merged 2 commits into from
Dec 7, 2024
Merged

fix: improve searchbar colors #1871

merged 2 commits into from
Dec 7, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Dec 7, 2024

brighten the search box so that colored images don't affect text contrast.


Before:
Screenshot 2024-12-06 at 7 15 32 PM

After:
Screenshot 2024-12-06 at 7 14 31 PM
Screenshot 2024-12-06 at 7 14 41 PM


Before:

Screenshot 2024-12-06 at 7 15 16 PM

After:

Screenshot 2024-12-06 at 7 15 57 PM

Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Dec 7, 2024 0:07am
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Dec 7, 2024 0:07am

@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com December 7, 2024 00:07 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com December 7, 2024 00:07 — with GitHub Actions Error
@abvthecity abvthecity marked this pull request as ready for review December 7, 2024 00:07
@abvthecity abvthecity had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 7, 2024 00:08 — with GitHub Actions Failure
Copy link

github-actions bot commented Dec 7, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Dec 7, 2024

PR Preview

@dsinghvi
Copy link
Member

dsinghvi commented Dec 7, 2024

@abvthecity do you think it may be easier to just make it opaque?

Copy link

github-actions bot commented Dec 7, 2024

Playwright test results

passed  96 passed
flaky  2 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 4 seconds
commit  a01f1df

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › redirect

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@abvthecity abvthecity merged commit 39ff32b into main Dec 7, 2024
17 of 19 checks passed
@abvthecity abvthecity deleted the ajiang/fix-searchbar-colors branch December 7, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants