feat(openapi): x-fern-base-path #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - dashboard-dev.buildwithfern.com
GitHub Actions
Error
…atform into chdeskur/fern-base-path
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
packages/parsers/src/openapi/3.1/extensions/XFernBasePathConverter.node.ts
Outdated
Show resolved
Hide resolved
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
| } | ||
|
|
||
| parse(): void { | ||
| this.basePath = extendType<{ "x-fern-base-path"?: string }>(this.input)["x-fern-base-path"]; |
There was a problem hiding this comment.
we should put x-fern-base-path into a const at the top of the file, so that we can keep things in lockstep, my fault for not including this earlier, but there are examples in the last opened PR
chdeskur
had a problem deploying
to
Preview - dashboard-dev.buildwithfern.com
GitHub Actions
Error
| @@ -122,8 +124,11 @@ export class OperationObjectConverterNode extends BaseOpenApiV3_1ConverterNode< | |||
| } | |||
|
|
|||
| const path = this.path.startsWith("/") ? this.path.slice(1) : this.path; | |||
| const basePath = this.basePath?.convert(); | |||
| const pathParts = basePath ? [basePath].concat(path.split("/")) : path.split("/"); | |||
There was a problem hiding this comment.
nit: [basePath, ...path.split("/"))] is a slightly nicer syntax
RohinBhargava
approved these changes
Dec 4, 2024
Playwright test results
Details
Flaky testschromium › forward-proxy/nextjs.spec.ts › capture the flag Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app.buildwithfern.com
GitHub Actions
Error
chdeskur
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Error
…atform into chdeskur/fern-base-path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the node, corresponding logic, and tests to parse
x-fern-base-path