Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added domain host check to avoid open redirection #1860

Merged
merged 17 commits into from
Dec 11, 2024
Merged

Added domain host check to avoid open redirection #1860

merged 17 commits into from
Dec 11, 2024

Conversation

dubwub
Copy link
Contributor

@dubwub dubwub commented Dec 4, 2024

No description provided.

@dubwub dubwub requested a review from abvthecity as a code owner December 4, 2024 20:26
@dubwub dubwub had a problem deploying to Preview - app-dev.buildwithfern.com December 4, 2024 20:26 — with GitHub Actions Error
@dubwub dubwub had a problem deploying to Preview - app.buildwithfern.com December 4, 2024 20:26 — with GitHub Actions Error
@dubwub dubwub had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 4, 2024 20:27 — with GitHub Actions Error
@dubwub dubwub had a problem deploying to Preview - app.buildwithfern.com December 4, 2024 20:28 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - app-dev.buildwithfern.com December 4, 2024 20:28 — with GitHub Actions Error
@dubwub dubwub had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 4, 2024 20:29 — with GitHub Actions Error
@dubwub dubwub had a problem deploying to Preview - app-dev.buildwithfern.com December 4, 2024 20:32 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - app.buildwithfern.com December 4, 2024 20:32 — with GitHub Actions Failure
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

PR Preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Playwright test results

failed  1 failed
passed  90 passed
flaky  6 flaky
skipped  4 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 46 seconds
commit  fcdd74f

Failed tests

chromium › forward-proxy/express.spec.ts › revalidate-all/v4 should work with trailing slash

Flaky tests

chromium › forward-proxy/express.spec.ts › home page 404
chromium › forward-proxy/express.spec.ts › redirect
chromium › forward-proxy/express.spec.ts › sitemap.xml
chromium › forward-proxy/express.spec.ts › revalidate-all/v3 should work with trailing slash
chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › redirect

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request
chromium › websockets/websocket.spec.ts › websocket test

@dubwub dubwub force-pushed the dd/clean-logout-url branch from a589e56 to b46bb77 Compare December 6, 2024 00:18
@dubwub dubwub had a problem deploying to Preview - app.buildwithfern.com December 6, 2024 00:18 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - app-dev.buildwithfern.com December 6, 2024 00:18 — with GitHub Actions Error
@dubwub dubwub had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 6, 2024 00:19 — with GitHub Actions Error
@dubwub dubwub had a problem deploying to Preview - app-dev.buildwithfern.com December 6, 2024 00:22 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - app.buildwithfern.com December 6, 2024 00:22 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - app-dev.buildwithfern.com December 9, 2024 18:57 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - app.buildwithfern.com December 9, 2024 18:57 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 9, 2024 18:59 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 9, 2024 19:46 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 9, 2024 20:41 — with GitHub Actions Failure
@dubwub dubwub had a problem deploying to Preview - dashboard-dev.buildwithfern.com December 10, 2024 23:43 — with GitHub Actions Failure
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com December 11, 2024 00:39 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com December 11, 2024 00:39 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com December 11, 2024 00:40 — with GitHub Actions Failure
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com December 11, 2024 00:40 — with GitHub Actions Failure
@dsinghvi dsinghvi merged commit 2c5212b into main Dec 11, 2024
13 of 17 checks passed
@dsinghvi dsinghvi deleted the dd/clean-logout-url branch December 11, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

@abvthecity abvthecity abvthecity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dubwub @abvthecity @dsinghvi