Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changed header key to header name #1837

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • Changes the name of the FDR shapes from headerKey to headerName

What was the motivation & context behind this PR?

  • Better naming convention

How has this PR been tested?

  • In person demo

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Nov 19, 2024 5:25pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 19, 2024 5:25pm

@abvthecity abvthecity enabled auto-merge (squash) November 19, 2024 17:26
Copy link

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

Copy link

Playwright test results

passed  97 passed
flaky  1 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 13 seconds
commit  d5f95b0

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@abvthecity abvthecity merged commit 4442640 into main Nov 19, 2024
21 of 22 checks passed
@abvthecity abvthecity deleted the rohin/change-header-key-to-header-name branch November 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants