Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header fields in the api playground, and resetting user-entered token #1816

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Nov 14, 2024

  • header fields in the api playground passed in the wrong "value" field, which made it impossible to type and update the header state
  • if the injected api key is "", don't treat it as "logged in"
  • when clicking "reset", reset not only the bearer token but also the user-entered bearer token

@abvthecity abvthecity marked this pull request as ready for review November 14, 2024 23:25
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com 🔄 Building (Inspect) Visit Preview Nov 14, 2024 11:25pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 14, 2024 11:25pm

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

PR Preview

Copy link

Playwright test results

passed  97 passed
flaky  1 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 11 seconds
commit  a5f79d3

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@abvthecity abvthecity merged commit 0bc99e5 into main Nov 15, 2024
19 of 20 checks passed
@abvthecity abvthecity deleted the ajiang/fix-api-playground-form-state branch November 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants