Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error example dropdown issues #1815

Merged
merged 4 commits into from
Nov 15, 2024
Merged

fix: error example dropdown issues #1815

merged 4 commits into from
Nov 15, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Nov 14, 2024

  • rewrote the logic that generates the complex input shape for code snippets
  • key by request code, and dedupe by response json
  • added plenty of redundancies in "selecting" the code example, so that it should never fail to resolve a request/response shape despite external influences (i.e. local storage, which was previously causing examples to disappear)
  • clicking outside of the errors block will deselect the error snippet on the right
  • slightly improved the rendering of the select dropdown

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com 🔄 Building (Inspect) Visit Preview Nov 14, 2024 10:46pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 14, 2024 10:46pm

Copy link

github-actions bot commented Nov 14, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 14, 2024

PR Preview

Copy link

github-actions bot commented Nov 14, 2024

Playwright test results

passed  95 passed
flaky  3 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 31 seconds
commit  bcdece3

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › redirect
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.anterior.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@abvthecity abvthecity merged commit 873c18e into main Nov 15, 2024
19 of 20 checks passed
@abvthecity abvthecity deleted the ajiang/fix-curl-example branch November 15, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants