Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: plumb roles through root node for consumption with generating roles in search records #1804

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • plumbs through an optional roles property to give the full set of roles available for use in docs
  • dependency for encoding permissions
  • optional for now, to not create a breaking change with back-compat (can potentially think about making required in future)

What was the motivation & context behind this PR?

  • show how we can segment algolia search records based on RBAC

How has this PR been tested?

  • to be tested in toy app for search v3

@RohinBhargava RohinBhargava marked this pull request as ready for review November 8, 2024 15:56
Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Nov 8, 2024 4:03pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 8, 2024 4:03pm

Copy link

github-actions bot commented Nov 8, 2024

Copy link

github-actions bot commented Nov 8, 2024

Copy link

github-actions bot commented Nov 8, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 8, 2024

@RohinBhargava RohinBhargava enabled auto-merge (squash) November 8, 2024 16:08
Copy link

github-actions bot commented Nov 8, 2024

PR Preview

Copy link

github-actions bot commented Nov 8, 2024

Playwright test results

passed  95 passed
flaky  3 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 35 seconds
commit  eabae06

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › redirect
chromium › forward-proxy/nextjs.spec.ts › client-side navigation

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@RohinBhargava RohinBhargava merged commit c6eddc5 into main Nov 8, 2024
20 of 22 checks passed
@RohinBhargava RohinBhargava deleted the rohin/fdr-plumb-all-roles branch November 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants