fix: authed previews in production redirect to the CDN URI #1803
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
|
||
| const redirectUri = process.env.NEXT_PUBLIC_CDN_URI != null | ||
| ? urlJoin(removeTrailingSlash(withDefaultProtocol(process.env.NEXT_PUBLIC_CDN_URI)), "/api/fern-docs/auth/sso/callback") | ||
| : urlJoin(removeTrailingSlash(withDefaultProtocol(host)), "/api/fern-docs/auth/sso/callback"); |
There was a problem hiding this comment.
this is the key logic change -- i added it for all callers, is that right? @abvthecity
There was a problem hiding this comment.
I would do something like this:
String(new URL("/api/fern-docs/auth/sso/callback", withDefaultProtocol(process.env.NEXT_PUBLIC_CDN_URI ?? host)))
📦 Next.js Bundle Analysis for fern-platform-monorepoThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Playwright test results
Details
Flaky testschromium › forward-proxy/nextjs.spec.ts › capture the flag Skipped testschromium › posthog.spec.ts › Posthog loads successfully |
dsinghvi
had a problem deploying
to
Preview - app-dev.buildwithfern.com
GitHub Actions
Failure
Short description of the changes made
In production, we should redirect to
app.buildwithfern.comWhat was the motivation & context behind this PR?
Make sure redirect URIs work in production WorkOS auth
How has this PR been tested?
N/A