Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure authorization url had state #1802

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Nov 7, 2024

Short description of the changes made

Authed Preview URL shoudl redirect to the right URL

What was the motivation & context behind this PR?

Support authed preview urls

How has this PR been tested?

Will test on dev

@dsinghvi dsinghvi requested a review from abvthecity as a code owner November 7, 2024 17:53
Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rbac.ferndocs.com ❌ Failed (Inspect) Nov 7, 2024 5:53pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Nov 7, 2024 5:53pm

Copy link

github-actions bot commented Nov 7, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 7, 2024

PR Preview

Copy link

github-actions bot commented Nov 7, 2024

Playwright test results

failed  1 failed
passed  91 passed
flaky  6 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  2 minutes, 19 seconds
commit  1d50c9a

Failed tests

chromium › smoke/versioned-docs.spec.ts › Check if https://docs.flagright.com/framl-api/guides/overview/introduction is online

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › smoke/versioned-docs.spec.ts › Check if https://humanloop.com/docs/v5/api-reference is online
chromium › smoke/versioned-docs.spec.ts › Check if https://primer.io/docs/api/v2.2/introduction/getting-started is online
chromium › smoke/versioned-docs.spec.ts › Check if https://primer.io/docs/api/v2.1/api-reference/client-session-api/retrieve-client-side-token is online
chromium › smoke/versioned-docs.spec.ts › Check if https://docs.flagright.com/guides/overview/introduction is online
chromium › stylesheet/index.spec.ts › Check CSS variable values

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@dsinghvi dsinghvi merged commit ad08da0 into main Nov 7, 2024
18 of 20 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/setup-state-in-auth-url branch November 7, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants