Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rohin/debug discriminated unions algolia #1724

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

RohinBhargava
Copy link
Member

Short description of the changes made

  • Sets a depth limit -- some union visitation was simply too deep for recursion to handle.
  • Adds tests on tricky specs.

What was the motivation & context behind this PR?

  • Failed generation.

How has this PR been tested?

  • Two new snapshot tests.

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Oct 25, 2024 7:21pm

undiscriminatedUnionVariants: Set<string> = new Set(),
depth: number = 0,
): AlgoliaSearchRecord[] {
if (depth >= 8) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key change

Copy link

github-actions bot commented Oct 25, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@abvthecity abvthecity enabled auto-merge (squash) October 25, 2024 19:23
@abvthecity abvthecity disabled auto-merge October 25, 2024 19:23
Copy link

github-actions bot commented Oct 25, 2024

PR Preview

Copy link

github-actions bot commented Oct 25, 2024

Playwright test results

passed  95 passed
flaky  2 flaky
skipped  3 skipped

Details

stats  100 tests across 9 suites
duration  1 minute, 23 seconds
commit  a29e0b6

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › redirect

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

@RohinBhargava RohinBhargava enabled auto-merge (squash) October 25, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants