Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "fix: disconnect after x messages to illustrate how websockets work"" #1707

Merged

Conversation

RohinBhargava
Copy link
Member

Reverts #1705

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
fern-shell ⬜️ Ignored (Inspect) Oct 24, 2024 2:57pm

Copy link

Copy link

github-actions bot commented Oct 24, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Oct 24, 2024

PR Preview

Copy link

github-actions bot commented Oct 24, 2024

Playwright test results

passed  97 passed
flaky  1 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 1 second
commit  e59c1d4

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

Copy link

@fern-support fern-support had a problem deploying to Preview - app-dev.buildwithfern.com October 25, 2024 20:14 — with GitHub Actions Error
@fern-support fern-support had a problem deploying to Preview - app.buildwithfern.com October 25, 2024 20:14 — with GitHub Actions Error
Copy link

Copy link

@RohinBhargava RohinBhargava merged commit 55c05d9 into main Oct 25, 2024
20 of 21 checks passed
@RohinBhargava RohinBhargava deleted the revert-1705-revert-1694-rohin/websocket-20-records-disconnect branch October 25, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants