Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump ws from 8.17.0 to 8.17.1 #1692

Merged
merged 7 commits into from
Oct 26, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 22, 2024

Bumps ws from 8.17.0 to 8.17.1.

Release notes

Sourced from ws's releases.

8.17.1

Bug fixes

  • Fixed a DoS vulnerability (#2231).

A request with a number of headers exceeding the[server.maxHeadersCount][] threshold could be used to crash a ws server.

const http = require('http');
const WebSocket = require('ws');
const wss = new WebSocket.Server({ port: 0 }, function () {
const chars = "!#$%&'*+-.0123456789abcdefghijklmnopqrstuvwxyz^_`|~".split('');
const headers = {};
let count = 0;
for (let i = 0; i < chars.length; i++) {
if (count === 2000) break;
for (let j = 0; j &lt; chars.length; j++) {
  const key = chars[i] + chars[j];
  headers[key] = 'x';
if (++count === 2000) break;
}

}
headers.Connection = 'Upgrade';
headers.Upgrade = 'websocket';
headers['Sec-WebSocket-Key'] = 'dGhlIHNhbXBsZSBub25jZQ==';
headers['Sec-WebSocket-Version'] = '13';
const request = http.request({
headers: headers,
host: '127.0.0.1',
port: wss.address().port
});
request.end();
});

The vulnerability was reported by Ryan LaPointe in websockets/ws#2230.

In vulnerable versions of ws, the issue can be mitigated in the following ways:

  1. Reduce the maximum allowed length of the request headers using the [--max-http-header-size=size][] and/or the [maxHeaderSize][] options so that no more headers than the server.maxHeadersCount limit can be sent.

... (truncated)

Commits
  • 3c56601 [dist] 8.17.1
  • e55e510 [security] Fix crash when the Upgrade header cannot be read (#2231)
  • 6a00029 [test] Increase code coverage
  • ddfe4a8 [perf] Reduce the amount of crypto.randomFillSync() calls
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot requested a review from abvthecity as a code owner October 22, 2024 16:45
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 22, 2024
@dependabot dependabot bot requested a review from dsinghvi as a code owner October 22, 2024 16:45
@dependabot dependabot bot had a problem deploying to Preview - app-dev.buildwithfern.com October 22, 2024 16:45 Failure
@dependabot dependabot bot had a problem deploying to Preview - app.buildwithfern.com October 22, 2024 16:45 Failure
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-8.17.1 branch from 3d6b2f1 to 0dca7f6 Compare October 23, 2024 17:12
@dependabot dependabot bot had a problem deploying to Preview - app.buildwithfern.com October 23, 2024 17:12 Failure
@dependabot dependabot bot had a problem deploying to Preview - app-dev.buildwithfern.com October 23, 2024 17:12 Failure
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-8.17.1 branch from 0dca7f6 to 78c202c Compare October 23, 2024 23:02
@dependabot dependabot bot had a problem deploying to Preview - app.buildwithfern.com October 23, 2024 23:02 Failure
@dependabot dependabot bot had a problem deploying to Preview - app-dev.buildwithfern.com October 23, 2024 23:02 Failure
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-8.17.1 branch from 78c202c to 4923478 Compare October 24, 2024 00:17
@dependabot dependabot bot had a problem deploying to Preview - app-dev.buildwithfern.com October 24, 2024 00:17 Failure
@dependabot dependabot bot had a problem deploying to Preview - app.buildwithfern.com October 24, 2024 00:17 Failure
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-8.17.1 branch from 4923478 to 7d52ded Compare October 24, 2024 17:05
@dependabot dependabot bot had a problem deploying to Preview - app-dev.buildwithfern.com October 24, 2024 17:06 Failure
@dependabot dependabot bot had a problem deploying to Preview - app.buildwithfern.com October 24, 2024 17:06 Failure
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-8.17.1 branch from 7d52ded to bd25dba Compare October 24, 2024 17:24
@dependabot dependabot bot had a problem deploying to Preview - app.buildwithfern.com October 24, 2024 17:24 Failure
@dependabot dependabot bot had a problem deploying to Preview - app-dev.buildwithfern.com October 24, 2024 17:24 Failure
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ws-8.17.1 branch from bd25dba to 2bf98a8 Compare October 24, 2024 20:02
@dependabot dependabot bot had a problem deploying to Preview - app.buildwithfern.com October 24, 2024 20:02 Failure
@dependabot dependabot bot had a problem deploying to Preview - app-dev.buildwithfern.com October 24, 2024 20:02 Failure
Copy link

github-actions bot commented Oct 25, 2024

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Oct 25, 2024

PR Preview

Copy link

github-actions bot commented Oct 25, 2024

Playwright test results

passed  94 passed
flaky  4 flaky
skipped  3 skipped

Details

stats  101 tests across 10 suites
duration  1 minute, 37 seconds
commit  46177f7

Flaky tests

chromium › forward-proxy/nextjs.spec.ts › capture the flag
chromium › forward-proxy/nextjs.spec.ts › 404
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for docs.aiaplatform.com.au
chromium › smoke/favicon.spec.ts › Check if favicon exists and URL does not return 404 for fern.assemblyai.com

Skipped tests

chromium › posthog.spec.ts › Posthog loads successfully
chromium › proxy.spec.ts › multipart-form upload
chromium › proxy.spec.ts › json request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants