Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skew protection on prefetch without interfering with proxy #1660

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

abvthecity
Copy link
Contributor

@abvthecity abvthecity commented Oct 12, 2024

Link to fix in our fork of next.js: fern-api/next.js@0e4d20b

@abvthecity abvthecity changed the title fix: skew protection in next.js fix: skew protection on prefetch without interfering with proxy Oct 12, 2024
@abvthecity abvthecity had a problem deploying to Preview - app.buildwithfern.com October 12, 2024 13:58 — with GitHub Actions Error
@abvthecity abvthecity had a problem deploying to Preview - app-dev.buildwithfern.com October 12, 2024 13:58 — with GitHub Actions Error
Copy link

github-actions bot commented Oct 12, 2024

Playwright test results

passed  1 passed

Details

stats  1 test across 1 suite
duration  9.1 seconds
commit  d74e897

Copy link

📦 Next.js Bundle Analysis for fern-platform-monorepo

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 162.6 KB (🟢 -94.68 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/404 333 B 162.93 KB 46.55%
/dynamic/[domain]/[[...slug]] 52.7 KB 215.3 KB 61.51%
/static/[domain]/[[...slug]] 52.7 KB 215.3 KB 61.51%

@abvthecity abvthecity marked this pull request as ready for review October 12, 2024 14:04
@abvthecity abvthecity requested a review from dsinghvi as a code owner October 12, 2024 14:04
@abvthecity abvthecity enabled auto-merge (squash) October 12, 2024 14:04
Copy link

PR Preview

Copy link

Playwright test results

passed  81 passed

Details

stats  81 tests across 3 suites
duration  1 minute, 13 seconds
commit  d74e897

@abvthecity
Copy link
Contributor Author

Preview @fern-ui/docs-bundle / analyze (pull_request) is failing right now but will success the next time a PR is open

@abvthecity abvthecity merged commit 07c196c into main Oct 12, 2024
21 of 23 checks passed
@abvthecity abvthecity deleted the ajiang/skew-protection-fetch branch October 12, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants